refactor: convert rhs_sidebar component to ts #527
+51
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiggin77
added
2: Dev Review
raghavaggarwal2308
requested changes
Oct 9, 2024
There was a problem hiding this comment.
@hereje Mostly looks good to me. Just one small comment for discussion.
- convert component to ts - update types Fixes: mattermost#425
- update props types as optional according to original jsx component
hereje
force-pushed
the
refactor/convert-rhs_sidebar-to-ts
branch
from
9c97a43
to
1696ffd
Compare
raghavaggarwal2308
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor: convert rhs_sidebar component to ts
Ticket Link
Fixes: #425