Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-232]: Fixed the issue of same message being received while creating and deleting tags #524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 17, 2024

Summary

Fixed the issue of the same message being received while creating and deleting tags

Screenshots

Existing

Screenshot from 2024-09-05 14-08-02

Updated

Screenshot from 2024-09-05 14-02-56

How to test

  • Setup GitLab plugin, connect to the user, and create a subscription for a repo
  • Create/Delete a tag on the repo

Ticket:

Fixes #232

@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Sep 21, 2024
@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 21, 2024
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tag message is shown when a tag is deleted
3 participants