[MM-387]: Added support to subscribe to release and deployment #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiggin77
reviewed
Aug 7, 2024
wiggin77
reviewed
Aug 7, 2024
wiggin77
reviewed
Aug 7, 2024
| @@ -74,6 +74,8 @@ func (g *gitlab) NewGroupHook(ctx context.Context, user *UserInfo, token *oauth2 | |||
| JobEvents: &webhookOptions.JobEvents, | |||
| PipelineEvents: &webhookOptions.PipelineEvents, | |||
| WikiPageEvents: &webhookOptions.WikiPageEvents, | |||
| DeploymentEvents: &webhookOptions.DeploymentEvents, | |||
| ReleasesEvents: &webhookOptions.ReleaseEvents, | |||
There was a problem hiding this comment.
This is called ReleaseEvents everywhere else.
There was a problem hiding this comment.
@wiggin77 the key ReleasesEvents is used in AddGroupHookOptions struct from the github.com/xanzy/go-gitlab package. It is predefined as ReleasesEvents there.
There was a problem hiding this comment.
Can we not at least be consistent within our own code?
wiggin77
reviewed
Aug 7, 2024
| @@ -111,6 +113,8 @@ func (g *gitlab) NewProjectHook(ctx context.Context, user *UserInfo, token *oaut | |||
| JobEvents: &webhookOptions.JobEvents, | |||
| PipelineEvents: &webhookOptions.PipelineEvents, | |||
| WikiPageEvents: &webhookOptions.WikiPageEvents, | |||
| DeploymentEvents: &webhookOptions.DeploymentEvents, | |||
| ReleasesEvents: &webhookOptions.ReleaseEvents, | |||
There was a problem hiding this comment.
@wiggin77, Similar to #515 (comment)
wiggin77
reviewed
Aug 7, 2024
| @@ -52,6 +52,14 @@ func (fakeWebhookHandler) HandleJobs(_ context.Context, _ *gitlabLib.JobEvent) ( | |||
| return nil, nil | |||
| } | |||
|
|
|||
| func (fakeWebhookHandler) HandleDeployment(_ context.Context, _ *gitlabLib.DeploymentEvent) ([]*webhook.HandleWebhook, error) { | |||
There was a problem hiding this comment.
Are there are any unit tests for these?
There was a problem hiding this comment.
@wiggin77, Added them, Please have a look
wiggin77
added
2: Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to subscribe to release and deployment.
Screenshots
Issue link
Fixes #387
What to Test