Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-147] Updated log statements #444

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 commented Jan 18, 2024

Summary

  • Updated log statements
  • Removed unnecessary logs

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 33.40%. Comparing base (53b10f3) to head (ad68089).

Files Patch % Lines
server/plugin.go 23.70% 101 Missing and 2 partials ⚠️
server/api.go 0.00% 40 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   34.02%   33.40%   -0.62%     
==========================================
  Files          22       22              
  Lines        4021     4185     +164     
==========================================
+ Hits         1368     1398      +30     
- Misses       2515     2647     +132     
- Partials      138      140       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Gentle reminder for review

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 6, 2024
@mickmister
Copy link
Contributor

I'm not sure if we should go through with this logging approach in general. @hanzei What are your thoughts on this?

@hanzei
Copy link
Collaborator

hanzei commented Mar 15, 2024

The diff looks off. Maybe the PR needs to get rebased onto verbose-logging-for-token-debugging?

@raghavaggarwal2308
Copy link
Contributor Author

@hanzei The branch MM-147 is in sync with the base branch. We have removed some unnecessary log statements from the code in this PR.

@mickmister
Copy link
Contributor

@raghavaggarwal2308 We can have this PR point to master instead

@raghavaggarwal2308 raghavaggarwal2308 changed the base branch from verbose-logging-for-token-debugging to master March 28, 2024 07:28
@raghavaggarwal2308
Copy link
Contributor Author

@mickmister updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants