For posterity:

Commands used (and duplicates because duplicate webhooks..):

$ git tag -s v1.0.4 
$ git push origin v1.0.04
$ git push --delete v1.0.4

Content of the pastee:

08:19
johan/dotfiles New tag v1.0.4 by Johan Guldmyr: 4
-----BEGIN PGP SIGNATURE-----
MYSIG
-----END PGP SIGNATURE-----

08:19
johan/dotfiles New tag v1.0.4 by Johan Guldmyr: 4
-----BEGIN PGP SIGNATURE-----

MYSIG

-----END PGP SIGNATURE-----

08:20
johan/dotfiles New tag v1.0.4 by Johan Guldmyr:

08:20
johan/dotfiles New tag v1.0.4 by Johan Guldmyr:
~                                                   

I would like to work on it.

Awesome, thanks @Quaqmre 👍

Hi guys , I was working on this issue then I find some that ,It is not related webhoos or Mattermost api , when u try to delete tag remotely like ' git push --delete anytag' that is deleted gitlab remoot repo but anytag still there in your local repo. And when u try to push or delete any tag git add the *anytag" again.Then u saw 2 message on your channel 1 message about deleted mesage the other one is brendnew tag with the same name deleted one. Because u have the deleted tag in your local repo.When u delete tags remotely u have to delete in your local repo.

I will upload screenshot tomorrow morning :)

@jsmestad In order to delete a tag locally and remotely, you have to also run git tag -d anytag.

That seems like the expected behavior to me. git push will publish v4 again, given that it was not deleted locally.

@hanzei How should we proceed about this issue ? Can you help me what should i do ?

@Quaqmre The example looks good to me. The notifications appear in the right order. Would you please create a WIP PR for an early code review?

@hanzei Actually I dont know how can I create WIP PR , I try to create PR but I dont have any commit or changes ,so I cant create PR without changes what sould I do ?

` Showing with 0 additions and 0 deletions.

No commit comments for this range
`
I got those messages.After click create new Pull Request.

@Quaqmre Are you saying that you are unable to reproduce the issue?

Unfortunately, I cannot test this as I'm on holiday, but I can try again in like 3-4 weeks.

@Quaqmre To which branch did you pushed your changes? Did you tried creating the PR via https://github.com/mattermost/mattermost-plugin-gitlab/compare?

I can still reproduce this with:

In a private mattermost 5.28.1 channel (and gitlab plugin 1.3.0) I ran:
/gitlab subscribe johan/dotfiles tag

Then in my git repo I ran:

$ git tag v1.0.7
$ git push origin v1.0.7
Total 0 (delta 0), reused 0 (delta 0)
To mygitlab.example.org:johan/dotfiles.git
 * [new tag]         v1.0.7 -> v1.0.7
 *
$  git push origin --delete v1.0.7
To mygitlab.example.org:johan/dotfiles.git
 - [deleted]         v1.0.7

Resulted in these two gitlab notifications:

08:42
johan/dotfiles New tag v1.0.7 by : 

08:43

johan/dotfiles New tag v1.0.7 by : 

For this issue - There may value in continuing to deliver the tag deletion events.

An alternative may simply be to clarify this behavior in the help. @aaronrothschild may have some thoughts here.
cc @Quaqmre ☝️

@DHaussermann @wiggin77
I looked into the issue and would like to share my findings.

• The webhook event sent by GitLab in both cases (creation and deletion of a tag) is identical. Unfortunately, no parameter in the webhook payload indicates whether the tag push event is a creation or deletion event.
• One potential solution is to make an additional API call to retrieve the commit data, which might help us differentiate between these types of events.

Please let us know if making an extra API call is a viable approach to resolving this issue and whether we should proceed in this direction.`

• One potential solution is to make an additional API call to retrieve the commit data, which might help us differentiate between these types of events.

@Kshitij-Katiyar Let's try and see if it works.