-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zkstack_cli): Autocompletion support #3097
base: main
Are you sure you want to change the base?
Conversation
.join(format!(".{}rc", shell)); | ||
|
||
if shell_rc.exists() { | ||
let shell_rc_content = std::fs::read_to_string(&shell_rc)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot fail during this process. Let's handle errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in bc7d89e
use ethers::contract::Abigen; | ||
use eyre::ContextCompat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try to use anyhow?
seems it's the only place where we use eyre
What ❔
Add autocomplete feature to zkstack:
Why ❔
Checklist
zkstack dev fmt
andzkstack dev lint
.