Code refactoried a little bit from previous merge #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the root cause, but I can add one line test code to prove and track it for now. Well while I was adding such line and compiling, I got a compiler warning about the std::tmpnam(nullptr) therefore I just made few more changes to replace it with mkdtemp, and a wrapper to ensure temporary folder is deleted always.
…lude: 1) Check if serve path is directory other than file; 2) Use C++ RAII other than memory on stack to hold returned real path from realpath(); 3) Added few more test cases.
…other than dynamically allocating/de-allocating every time a static file is requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes: