Found a bug that could crash the server. Make one more test line to track it first. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the root cause, but I can add one line test code to prove and track it for now. Well while I was adding such line and compiling, I got a compiler warning about the std::tmpnam(nullptr) therefore I just made few more changes to replace it with mkdtemp, and a wrapper to ensure temporary folder is deleted always.
|
Okay, build failed with same test failure. It reproduces on CI environment too. |
|
Thanks a lot for the report @cong1920 . I fixed this bug in my last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @matt-42
You don't have to merge this PR because I just use it to submit a bug. I haven't figured out the cause yet but the new test code (line 32) can repro and track it. Please just copy-n-paste and give a shot to see if it repros on your side. And I believe your understanding of code and sharp eyes will find the root cause easily, which would save me tons of time :)
Well while I was adding such line and compiling, I got a compiler warning about the std::tmpnam(nullptr) therefore I just made few more changes to replace it with mkdtemp, and a wrapper to ensure temporary folder is deleted always. You can ignore these noise for now.