Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in fetch #23

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fixed bug in fetch #23

merged 1 commit into from
Jun 16, 2020

Conversation

Woazim
Copy link
Contributor

@Woazim Woazim commented Jun 15, 2020

the fetch function was buggy due to the reset of the "ready_for_reading_" flag. -> this reinitialized the SQL request by forcing the call to the operator () at next fetch call.

I just use SQLite, I didn't check other RDBMS...

the fetch function was buggy due to the reset of the "ready_for_reading_" flag. -> this reinitialized the SQL request by forcing the call to the operator () at next fetch call.
@matt-42
Copy link
Owner

matt-42 commented Jun 16, 2020

Thanks for the fix. The sql and pgsql does not use this. Actually I think we can get rid of this flag, it was there so you could write connection("select 1+2").read() instead of connection("select 1+2")().read() but I find it misleading now. I'll open an issue for this.

@matt-42 matt-42 merged commit e2fc2aa into matt-42:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants