cleanup

matschik · Apr 19, 2023 · cb4a3ae · cb4a3ae
1 parent 1b6fb5c
commit cb4a3ae
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 20 deletions.
diff --git a/content/1-reactivity/1-declare-state/mithril/Name.js b/content/1-reactivity/1-declare-state/mithril/Name.js
@@ -4,6 +4,6 @@ export default function Name() {
   let name = "John";
 
   return {
-    view: () => m("h1", name),
+    view: () => m("h1", `Hello ${name}`),
   };
 }
diff --git a/content/1-reactivity/2-update-state/mithril/Name.js b/content/1-reactivity/2-update-state/mithril/Name.js
@@ -2,11 +2,8 @@ import m from "mithril";
 
 export default function Name() {
   let name = "John";
-  setTimeout(() => {
-    name = "Jane";
-    m.redraw();
-  }, 1000);
+  name = "Jane";
   return {
-    view: () => m("h1", name),
+    view: () => m("h1", `Hello ${name}`),
   };
 }
diff --git a/content/1-reactivity/3-computed-state/mithril/DoubleCount.js b/content/1-reactivity/3-computed-state/mithril/DoubleCount.js
@@ -2,11 +2,8 @@ import m from "mithril";
 
 export default function DoubleCount() {
   let count = 10;
-  setTimeout(() => {
-    count = count * 2;
-    m.redraw();
-  });
+  let doubleCount = count * 2;
   return {
-    view: () => m("div", count),
+    view: () => m("div", doubleCount),
   };
 }
diff --git a/content/2-templating/3-loop/mithril/Colors.js b/content/2-templating/3-loop/mithril/Colors.js
@@ -6,7 +6,7 @@ export default function Colors() {
     view: () =>
       m(
         "ul",
-        colors.map((color) => m("li", { key: color }, color))
+        colors.map((color, idx) => m("li", { key: idx }, color))
       ),
   };
 }
diff --git a/content/2-templating/4-event-click/mithril/Counter.js b/content/2-templating/4-event-click/mithril/Counter.js
@@ -6,7 +6,7 @@ export default function Counter() {
   return {
     view: () =>
       m(
-        "",
+        "div",
         m("p", `Counter: ${count}`),
         m("button", { onclick: incrementCount }, "+1")
       ),

diff --git a/content/2-templating/6-conditional/mithril/TrafficLight.js b/content/2-templating/6-conditional/mithril/TrafficLight.js
@@ -3,15 +3,15 @@ const TRAFFIC_LIGHTS = ["red", "orange", "green"];
 
 export default function TrafficLight() {
   let lightIndex = 0;
-  let light = () => TRAFFIC_LIGHTS[lightIndex];
+  let currentLight = () => TRAFFIC_LIGHTS[lightIndex];
 
   const nextLight = () =>
     lightIndex + 1 > TRAFFIC_LIGHTS.length - 1
       ? (lightIndex = 0)
       : (lightIndex = lightIndex + 1);
 
   const instructions = () => {
-    switch (light()) {
+    switch (currentLight()) {
       case "red":
         return "STOP";
       case "orange":
@@ -24,9 +24,9 @@ export default function TrafficLight() {
   return {
     view: () =>
       m(
-        "",
+        "div",
         m("button", { onclick: nextLight }, "Next light"),
-        m("p", `Light is: ${light()}`),
+        m("p", `Light is: ${currentLight()}`),
         m("p", "You must ", m("span", instructions()))
       ),
   };

diff --git a/content/3-lifecycle/1-on-mount/mithril/PageTitle.js b/content/3-lifecycle/1-on-mount/mithril/PageTitle.js
@@ -1,9 +1,7 @@
 import m from "mithril";
 
 export default function PageTitle() {
-  let pageTitle = document.title;
-
   return {
-    view: () => m("p", `Page title: ${pageTitle}`),
+    view: () => m("p", `Page title: ${document.title}`),
   };
 }