fifocache: make queue1 size configurable #21301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusee
requested review from
LeftHandCold,
XuPeng-SH and
fengttt
as code owners
fengttt
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Can you add comment in the PR description or in the issue (or linking issue), that what is the workload, what is the target/result that we hope this queue size to achieve, and what is the default, what is changed, and what is the impact to "general" workload.
Any I don't think the title of the PR is accurate -- I don't see any "configurable" parameters and it is still the magic /10, simply moved to a different place. It is fine to hard code magic numbers -- if we believe these numbers are reasonable and it does not make sense to let user/dba tune it. Actually this is preferred, the less knobs the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #20296
What this PR does / why we need it:
make queue1 larger for the disk cache to prevent too aggressively eviction