fix leak check hung to 2.0 (#21341)

fix leak check hung Approved by: @xzxiong, @sukki37
matrixorigin · Jan 26, 2025 · dab188a · dab188a
1 parent 2873ce3
commit dab188a
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/pkg/txn/client/leak_checker.go b/pkg/txn/client/leak_checker.go
@@ -101,25 +101,27 @@ func (lc *leakChecker) check(ctx context.Context) {
 }
 
 func (lc *leakChecker) doCheck() []ActiveTxn {
-	lc.RLock()
-	defer lc.RUnlock()
-
-	var values []ActiveTxn
 	now := time.Now()
+	var values []ActiveTxn
+	lc.RLock()
 	for _, txn := range lc.actives {
 		if now.Sub(txn.CreateAt) >= lc.maxActiveAges {
-			if txn.txnOp != nil {
-				txn.Options.Counter = txn.txnOp.counter()
-				txn.Options.InRunSql = txn.txnOp.inRunSql()
-				txn.Options.InCommit = txn.txnOp.inCommit()
-				txn.Options.InRollback = txn.txnOp.inRollback()
-				txn.Options.InIncrStmt = txn.txnOp.inIncrStmt()
-				txn.Options.InRollbackStmt = txn.txnOp.inRollbackStmt()
-				txn.Options.SessionInfo = txn.txnOp.opts.options.SessionInfo
-			}
 			values = append(values, txn)
 		}
 	}
+	lc.RUnlock()
+
+	for _, txn := range values {
+		if txn.txnOp != nil {
+			txn.Options.Counter = txn.txnOp.counter()
+			txn.Options.InRunSql = txn.txnOp.inRunSql()
+			txn.Options.InCommit = txn.txnOp.inCommit()
+			txn.Options.InRollback = txn.txnOp.inRollback()
+			txn.Options.InIncrStmt = txn.txnOp.inIncrStmt()
+			txn.Options.InRollbackStmt = txn.txnOp.inRollbackStmt()
+			txn.Options.SessionInfo = txn.txnOp.opts.options.SessionInfo
+		}
+	}
 	return values
 }