Build docker on PRs, and inline docker GHA config #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 20, 2023 19:33
This config seemed to build arm wheels much more quickly and I've no idea why!?!!
This reverts commit c733ced.
DMRobertson
changed the title
poetry install verbosely
clokep
reviewed
Nov 20, 2023
| @@ -26,7 +26,7 @@ COPY --chown=sydent:sydent ["sydent", "sydent"] | |||
| COPY --chown=sydent:sydent ["README.rst", "pyproject.toml", "poetry.lock", "./"] | |||
|
|
|||
| # Install dependencies | |||
| RUN python -m poetry install --no-dev --no-interaction --extras "prometheus sentry" | |||
| RUN python -m poetry install -vv --no-dev --no-interaction --extras "prometheus sentry" | |||
There was a problem hiding this comment.
My thinking was to leave it in as it can't do any harm.
clokep
reviewed
Nov 20, 2023
clokep
reviewed
Nov 20, 2023
| @@ -59,6 +59,22 @@ jobs: | |||
| packaging: | |||
| uses: "matrix-org/backend-meta/.github/workflows/packaging.yml@v1" | |||
|
|
|||
| docker: | |||
| # Sanity check that we can build the x64 image | |||
There was a problem hiding this comment.
That was my thinking, yeah.
clokep
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release's CI hung. It's spent over 3 hours doing a docker build, and I've no idea why: https://github.com/matrix-org/sydent/actions/runs/6932931412
To try to debug this I tried:
poetry install -vv. I don't think this made much difference to the logs that were generated. Might need-vvv, or a newer Poetry version? (This repo uses 1.2.x in CI, I think.)I'd like to try this on
mainto see if the docker build magically becomes fast again.