Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate changelog release info with Hugo rather than when generating changelog #2033

Merged
merged 13 commits into from
Dec 23, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Dec 15, 2024

Since all the data is available in the frontmatter, we can just use Hugo to generate the release-info table, it allows to have more control over it, notably to:

  • Show a link to the checklist on the unstable changelog.
  • Generate only markdown in the checklist output format.

The second commit helps to detect the new expected date format in the generate-changelog.sh script.

Pull Request Checklist

Preview: https://pr2033--matrix-spec-previews.netlify.app

… changelog

Allows to have more control on the output, like showing a link to the checklist on the unstable changelog,
and using only markdown in the checklist output format.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner December 15, 2024 16:55
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
content/changelog/v1.1.md Show resolved Hide resolved
layouts/docs/changelog.html Show resolved Hide resolved
scripts/generate-changelog.sh Outdated Show resolved Hide resolved
Signed-off-by: Kévin Commaille <[email protected]>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, but otherwise LGTM. Nice set of cleanups!

changelogs/internal/newsfragments/2033.clarification Outdated Show resolved Hide resolved
layouts/docs/changelog.checklist.md Outdated Show resolved Hide resolved
layouts/docs/changelog.html Outdated Show resolved Hide resolved
scripts/generate-changelog.sh Outdated Show resolved Hide resolved
zecakeh and others added 4 commits December 23, 2024 16:04
Co-authored-by: Andrew Morgan <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the making the changes. This now LGTM!

meta/releasing.md Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) December 23, 2024 17:45
@anoadragon453 anoadragon453 merged commit 6f1e64c into matrix-org:main Dec 23, 2024
12 checks passed
@zecakeh zecakeh deleted the changelog-layout branch December 23, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants