MSC4233: Remembering which server a user knocked through #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
added
proposal
turt2live
commented
Nov 28, 2024
There was a problem hiding this comment.
Implementation requirements:
- Client(?)
- Server
turt2live
changed the title
ara4n
reviewed
Nov 28, 2024
| {"type": "m.room.name", "state_key": "", "content": {"name": "My Room"}} | ||
| ] | ||
| }, | ||
| "knock_servers": [ // new property |
There was a problem hiding this comment.
i wonder if via might be clearer?
ara4n
reviewed
Nov 28, 2024
| Servers may not have already tracked this, so information will be lacking for already-knocked rooms. | ||
| Clients should expect errors, per usual, when attempting to call the summary API or any other endpoint. | ||
|
|
||
| ## Alternatives |
There was a problem hiding this comment.
presumably another option would be for the server to silently remember the knock server on behalf of the client and add an implicit via when they provide a raw room id?
turt2live
commented
Nov 29, 2024
There was a problem hiding this comment.
This MSC also applies to rescinding knocks: servers don't know what server to make/send_leave through remotely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published with my role as a member of the SCT.