Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4227: Audio based quick login #4227

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

albertotirla
Copy link

@albertotirla albertotirla commented Nov 15, 2024

Rendered

Pull Request Checklist

This MSC gives visually impaired people a way to use the quick login mechanism, without having to scan a QR code, which is impossible to do reliably with any current assistive technologies

@uhoreg uhoreg added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 15, 2024
@thoraj
Copy link

thoraj commented Nov 15, 2024

While I agree with goals of this MSC, I'm very doubtful it will work as specified.

  • the use of morse code seem strange. Since morse code was invented, there have been numerous innovation of more efficient ways to transmit information over audio channels (FSK, DTMF or more advanced QAM methods)
  • the transmission must most likely use some form of error correcting code to get the desired accuracy
  • transmitting in the band 50khz-80khz (ultrasound) will be hard/impossible with standard phone hardware. Android samples at 44,1khz or 48khz afaik, which theoretically limits bandwidth to 22khz or 24khz (Nyquist limit)

Using more proven methods and protocols rather than inventing something new, seems more likely to succeed .

@albertotirla
Copy link
Author

I will look more indepth at FSK, because this one seemns quite promising. The problem is, as always, if we have bindings for this protocol for at least as many programming languages as we have matrix sdks. I looked at something similar before, and the problem with all these is that we don't have enough bindings for this stuff as we have for qr code generation and scanning, which is probably even less than other methods.

…either qr or audio login and add some more items to the issues section

Signed-off-by: Alberto Tirla <[email protected]>
Signed-off-by: Alberto Tirla <[email protected]>
@albertotirla albertotirla marked this pull request as ready for review November 18, 2024 02:22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Client
  • Server

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server is not required, this is a protocol between two clients which requires no API endpoints on the part of the homeserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants