Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4216: Set Maximum Allowed Tags #4216

Closed
wants to merge 6 commits into from
Closed

MSC4216: Set Maximum Allowed Tags #4216

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
122916e
added proposal 4216
lamoboos223 Oct 17, 2024
71611e8
reduced char on MSC4216
lamoboos223 Oct 21, 2024
9ec7246
add more descriptive proposal
lamoboos223 Oct 21, 2024
45432ac
add more descriptive proposal
lamoboos223 Oct 21, 2024
32856f3
added more description to MSC4216
lamoboos223 Oct 22, 2024
9ea9203
No changes this commit
lamoboos223 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions proposals/4216-limit-creating-same-tag.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
## MSC4216 Proposal

Admins should have the ability to limit tag usage, like restricting `u.pin` to **3** rooms, while tags like `u.archive` will remain unrestricted if **not defined**.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I see this purely as an implementation detail, not something that should be specified, but there might be value in clarifying semantics for things like M_LIMIT_EXCEEDED in certain contexts (eg. tags in this context).

Additionally: How would migrations canonically work? What happens if the admin lowers the limit to below the count users already have? Are tags even relevant in 2024, with most clients not even supporting custom tags to begin with? Is there a good benefit to limiting usage count of tags across clients?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
So the reason i was proposing this feature is because to priority tags and lazy loading their content/messages instead of loading the whole rooms with no tags defined. So for example if a user pinned 3 rooms, these 3 rooms will be asked for their content before the rest of the rooms and this will happen on the client side.

You make a good point about what would happen if the admin lower the amount of a tag, I actually didn’t think it through (I apologies).

@TheArcaneBrony

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure I see how this would be beneficial? You could just ask the server for all rooms, or add a new joined room on every subsequent request on sync.
Alternatively, you could do the same but request all DMs first? I'm not sure I see a tangible benefit here besides attempting to make initial sync faster, in which case... You could store a sorted list of rooms by member count in account data and handle future logins this way by referencing account data.

I'm not discrediting the idea here, just wondering what the train of thought is versus using heuristics transparently without requiring user involvement.


## Potential issues

NA

## Alternatives

NA

## Security considerations

NA

## Dependencies

This MSC has no dependencies.