test(sdk): Allow any MockEndpoint to override the expected access token #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of MockBuilder::respond_with. This reduces duplcation and will allow to add some common logic when building the endpoints. Signed-off-by: Kévin Commaille <[email protected]>
Allows to reduce duplication and will allow to add common logic. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
mock-access-token
branch
from
adfc612 to
1dbc239
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4773 +/- ##
==========================================
- Coverage 86.35% 86.31% -0.05%
==========================================
Files 291 291
Lines 34326 34266 -60
==========================================
- Hits 29643 29577 -66
- Misses 4683 4689 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes the behavior introduced in #4767 for the
/whoamimock endpoint.It requires creators of
MockEndpoints to use the built-in methods instead of custom methods onMockBuilderand sadly there is no way to enforce this programmatically.