feat!(timeline): Allow to send attachments from bytes #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4451 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 283 283
Lines 31748 31766 +18
=======================================
+ Hits 27005 27021 +16
- Misses 4743 4745 +2 ☔ View full report in Codecov by Sentry. |
…chment filename Since we need a String as final type, this can avoid to allocate a string if the provided type is already a String. Signed-off-by: Kévin Commaille <[email protected]>
Sometimes we can get the bytes directly. It avoids to have to write the data to a temporary file only to have the data loaded back in memory right after. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
timeline-send-attachment-bytes
branch
from
c47466a to
2a0973f
Compare
|
Added changelog entries in the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we can get the bytes directly, e.g. in Fractal we can get an image from the clipboard. It avoids to have to write the data to a temporary file only to have the data loaded back in memory by the SDK right after.
The first commit to accept any type that implements
Into<String>for the filename is grouped here because it simplifies slightly the second commit.Note that we could also use
AttachmentSourcein the othersend_attachmentAPIs, onRoomandRoomSendQueue, for consistency.