feat(event cache): start paginations from the most recent token, not the oldest token #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4393 +/- ##
==========================================
+ Coverage 85.16% 85.19% +0.02%
==========================================
Files 281 281
Lines 30924 30926 +2
==========================================
+ Hits 26337 26347 +10
+ Misses 4587 4579 -8 ☔ View full report in Codecov by Sentry. |
andybalaam
approved these changes
Dec 9, 2024
…e *oldest* one Whenever it needs to back-paginate, the event cache should start with the *most recent* backpagination token, not the oldest one. This isn't a functional change, until the persistent storage is enabled. The reason is that, currently, there is one previous-batch token alive; after it's used, it's replaced with another gap and the events it served to request from the server. When persistent storage will be enabled, we'll have situations like the one shown in the test code, where we can have multiple previous-batch token alive at the same time. In that case, we'll need to back-paginate from the most recent events to the least recent events, and not the other way around, or we'll have holes in the timeline that won't be filled until we got to the start of the timeline.
bnjbvr
force-pushed
the
bnjbvr/most-recent-prevbatch-token
branch
from
9d9d649 to
55dae88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3280. See the first commit message's description to get the reasoning.
Split from #4308.