-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean test files #7636
Clean test files #7636
Conversation
@sanchezzzhak I've made some changes to rewriteTestFixtureFiles.php to remove the whitespace from #6938 and ran it for all files. |
Only the versions that look like a int/float needed to be wrapped in a string version: 10
version: 1.0
version: 2.6 must be converted to version: "10"
version: "1.0"
version: "2.6" for in fact, when we use when creating a fixture through a tool
result user_agent: Mozilla/5.0 (Linux; arm_64; Android 13; CPH2333) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.2552 YaApp_Android/24.10.1 YaSearchBrowser/24.10.1 BroPP/1.0 SA/3 Mobile Safari/537.36
os:
name: Android
version: "13"
platform: ARM
client:
type: browser
name: Yandex Browser
version: 24.10.1
engine: Blink
engine_version: 120.0.6099.2552
device:
type: smartphone
brand: OPPO
model: A94
os_family: Android
browser_family: Unknown Unfortunately, the PHP yaml parser is not very strict, unlike python or nodejs. I suggest not adding this PR, as we have resolved the main criticisms. #7634 |
Fixes #7633