Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for various libraries, bots and operating systems #7498

Merged
merged 30 commits into from
Nov 14, 2023

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

regexes/oss.yml Outdated Show resolved Hide resolved
regexes/oss.yml Outdated Show resolved Hide resolved
sanchezzzhak
sanchezzzhak previously approved these changes Nov 7, 2023
@Simbiat
Copy link
Contributor

Simbiat commented Nov 7, 2023

While reviewing this, I've learnt that we have "Generic bot" entry. I wonder if we actually need it, since this is equivalent to "Unknown" in my mind.

@liviuconcioiu
Copy link
Collaborator Author

While reviewing this, I've learnt that we have "Generic bot" entry. I wonder if we actually need it, since this is equivalent to "Unknown" in my mind.

It's like a partial detection. We don't know which bot or for some bots there's no point adding them or there's not enough info. That's why this generic detection is used. Without it bots containing spider and Chrome would be detected as real visitors, which is false.

sanchezzzhak
sanchezzzhak previously approved these changes Nov 8, 2023
sanchezzzhak
sanchezzzhak previously approved these changes Nov 13, 2023
@sanchezzzhak sanchezzzhak merged commit 2357f77 into matomo-org:master Nov 14, 2023
15 checks passed
@liviuconcioiu liviuconcioiu deleted the devices branch November 14, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants