Fix version truncation for client hints (#7138)

matomo-org · Jun 10, 2022 · ec95993 · ec95993
1 parent 829935d
commit ec95993
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -817,7 +817,7 @@ protected function parseBrowserFromClientHints(): array
         return [
             'name'       => $name,
             'short_name' => $short,
-            'version'    => $version,
+            'version'    => $this->buildVersion($version, []),
         ];
     }
 

diff --git a/Parser/OperatingSystem.php b/Parser/OperatingSystem.php
@@ -439,7 +439,7 @@ protected function parseOsFromClientHints(): array
         return [
             'name'       => $name,
             'short_name' => $short,
-            'version'    => $version,
+            'version'    => $this->buildVersion($version, []),
         ];
     }
 

diff --git a/Tests/DeviceDetectorTest.php b/Tests/DeviceDetectorTest.php
@@ -290,6 +290,31 @@ public function getVersionTruncationFixtures(): array
         ];
     }
 
+    public function testVersionTruncationForClientHints(): void
+    {
+        AbstractParser::setVersionTruncation(AbstractParser::VERSION_TRUNCATION_MINOR);
+        $dd = new DeviceDetector();
+        $dd->setClientHints(new ClientHints(
+            'Galaxy 4',
+            'Android',
+            '8.0.5',
+            '98.0.14335.105',
+            [
+                ['brand' => ' Not A;Brand', 'version' => '99.0.0.0'],
+                ['brand' => 'Chromium', 'version' => '98.0.14335.105'],
+                ['brand' => 'Chrome', 'version' => '98.0.14335.105'],
+            ],
+            true,
+            '',
+            '',
+            ''
+        ));
+        $dd->parse();
+        $this->assertEquals('8.0', $dd->getOs('version'));
+        $this->assertEquals('98.0', $dd->getClient('version'));
+        AbstractParser::setVersionTruncation(AbstractParser::VERSION_TRUNCATION_NONE);
+    }
+
     /**
      * @dataProvider getBotFixtures
      */