Skip to content

Commit

Permalink
fix coding style
Browse files Browse the repository at this point in the history
  • Loading branch information
sgiehl committed Oct 28, 2019
1 parent 81cd99e commit 6093675
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
12 changes: 9 additions & 3 deletions Parser/Client/Browser.php
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,13 @@ class Browser extends AbstractClientParser
'Chrome Frame', 'CoolNovo', 'Chromium', 'ChromePlus', 'Iron', 'RockMelt', 'Amigo', 'TweakStyle', 'Vivaldi',
'Polarity', 'Avast Secure Browser', 'Tenta Browser', 'AOL Shield', 'Samsung Browser', 'Web Explorer',
'Iron Mobile', 'Chrome Webview', 'Whale Browser', 'Seznam Browser', 'QtWebEngine', 'LieBaoFast', 'Kiwi',
'2345 Browser', 'CM Browser', 'Ecosia', 'Mint Browser', 'Mobile Silk', 'DuckDuckGo Privacy Browser', 'Mobile Silk', 'Hawk Turbo Browser', 'Oculus Browser',
'2345 Browser', 'CM Browser', 'Ecosia', 'Mint Browser', 'Mobile Silk', 'DuckDuckGo Privacy Browser',
'Mobile Silk', 'Hawk Turbo Browser', 'Oculus Browser',
],
'Firefox' => [
'Firefox', 'Fennec', 'Firefox Mobile', 'Swiftfox', 'Firebird', 'Phoenix', 'MicroB', 'Epic', 'Waterfox',
'Cunaguaro', 'TenFourFox', 'Qwant Mobile', 'Firefox Rocket', 'IceCat', 'Mobicip', 'Firefox Mobile iOS', 'Basilisk',
'Cunaguaro', 'TenFourFox', 'Qwant Mobile', 'Firefox Rocket', 'IceCat', 'Mobicip', 'Firefox Mobile iOS',
'Basilisk',
],
'Internet Explorer' => ['Internet Explorer', 'IE Mobile', 'Microsoft Edge'],
'Konqueror' => ['Konqueror'],
Expand Down Expand Up @@ -370,7 +372,11 @@ public function parse(): ?array
}

// This Exception should never be thrown. If so a defined browser name is missing in $availableBrowsers
throw new \Exception(sprintf('Detected browser name "%s" was not found in $availableBrowsers. Tried to parse user agent: %s', $name, $this->userAgent)); // @codeCoverageIgnore
throw new \Exception(sprintf(
'Detected browser name "%s" was not found in $availableBrowsers. Tried to parse user agent: %s',
$name,
$this->userAgent
)); // @codeCoverageIgnore
}

/**
Expand Down
5 changes: 4 additions & 1 deletion Parser/Client/Browser/Engine.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ public function parse(): ?array
}

// This Exception should never be thrown. If so a defined browser name is missing in $availableEngines
throw new \Exception(sprintf('Detected browser engine was not found in $availableEngines. Tried to parse user agent: %s', $this->userAgent)); // @codeCoverageIgnore
throw new \Exception(sprintf(
'Detected browser engine was not found in $availableEngines. Tried to parse user agent: %s',
$this->userAgent
)); // @codeCoverageIgnore
}
}
8 changes: 7 additions & 1 deletion Parser/Device/AbstractDeviceParser.php
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,13 @@ public function parse(): ?array

if (false === $brandId) {
// This Exception should never be thrown. If so a defined brand name is missing in $deviceBrands
throw new \Exception(sprintf("The brand with name '%s' should be listed in the deviceBrands array. Tried to parse user agent: %s", $brand, $this->userAgent)); // @codeCoverageIgnore
throw new \Exception(
sprintf(
"The brand name '%s' needs to be in deviceBrands array. Tried parsing user agent: %s",
$brand,
$this->userAgent
)
); // @codeCoverageIgnore
}

$this->brand = (string) $brandId;
Expand Down

0 comments on commit 6093675

Please sign in to comment.