hotfix incorrect YAML attribute name in mobile-app.yml (#6692)

* fix(app) fix key `name` * feat(test) added test to check structure in mobile_apps.yml Co-authored-by: Tutik Alexsandr <[email protected]>
matomo-org · Feb 26, 2021 · 395f080 · 395f080
1 parent 3794d7b
commit 395f080
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/Tests/Parser/Client/MobileAppTest.php b/Tests/Parser/Client/MobileAppTest.php
@@ -32,4 +32,15 @@ public function getFixtures(): array
 
         return $fixtureData;
     }
+
+    public function testStructureMobileAppYml(): void
+    {
+        $ymlDataItems = Spyc::YAMLLoad(__DIR__ . '/../../../regexes/client/mobile_apps.yml');
+
+        foreach ($ymlDataItems as $item) {
+            $this->assertTrue(\array_key_exists('regex', $item), 'key "regex" not exist');
+            $this->assertTrue(\array_key_exists('name', $item), 'key "name" not exist');
+            $this->assertTrue(\array_key_exists('version', $item), 'key "version" not exist');
+        }
+    }
 }
diff --git a/Tests/fixtures/mobile_apps.yml b/Tests/fixtures/mobile_apps.yml
@@ -959,3 +959,19 @@
     model: iPhone
   os_family: iOS
   browser_family: Unknown
+-
+  user_agent: RadioPublic/android-2.2
+  os:
+    name: Android
+    version: ""
+    platform: ""
+  client:
+    type: mobile app
+    name: RadioPublic
+    version: "2.2"
+  device:
+    type: ""
+    brand: ""
+    model: ""
+  os_family: Android
+  browser_family: Unknown
diff --git a/regexes/client/mobile_apps.yml b/regexes/client/mobile_apps.yml
@@ -467,7 +467,7 @@
 
 # RadioPublic (https://play.google.com/store/apps/details?id=com.radiopublic.android)
 - regex: 'RadioPublic/android-(\d+[\.\d]+)'
-  ame: 'RadioPublic'
+  name: 'RadioPublic'
   version: '$1'
 
 # Podimo (https://play.google.com/store/apps/details?id=com.podimo)