Removed duplicate key ATVIO brand (#6965)

* fix: removed duplicate ATVIO brand * feat(test) added test testDuplicateBrands
matomo-org · Jan 13, 2022 · 0ef6636 · 0ef6636
1 parent 6b2b7ea
commit 0ef6636
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Parser/Device/AbstractDeviceParser.php b/Parser/Device/AbstractDeviceParser.php
@@ -165,7 +165,6 @@ abstract class AbstractDeviceParser extends AbstractParser
         'ZA' => 'Avenzo',
         'AH' => 'AVH',
         'AV' => 'Avvio',
-        'Y6' => 'ATVIO',
         'AY' => 'Axxion',
         'XA' => 'Axioo',
         'AM' => 'Azumi Mobile',

diff --git a/Tests/DeviceDetectorTest.php b/Tests/DeviceDetectorTest.php
@@ -525,6 +525,21 @@ public function testCheckRegexRestrictionEndCondition(): void
         $this->assertTrue($this->checkRegexRestrictionEndCondition('TestValue(?:[;)/]|$)'), 'pass condition');
     }
 
+    /**
+     * Checks the AbstractDeviceParser::$deviceBrands for duplicate brands
+     */
+    public function testDuplicateBrands(): void
+    {
+        $brands     = \array_map('strtolower', AbstractDeviceParser::$deviceBrands);
+        $unique     = \array_unique($brands);
+        $duplicates = \array_diff_assoc($brands, $unique);
+
+        $this->assertCount(0, $duplicates, \sprintf(
+            'Duplicate brands exists: %s',
+            \print_r($duplicates, true)
+        ));
+    }
+
     /**
      * check the Symfony parser for fixtures parsing errors
      */