Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct submodule url #722

Open
wants to merge 1 commit into
base: live
Choose a base branch
from
Open

Conversation

EPNW-Eric
Copy link
Contributor

It seems that the old submodule path does not work anymore and points to the old place of the repository. I've updated it accordingly.

It seems that the old submodule path does not work anymore and points to the old place of the repository.
I've updated it accordingly.
@michalkleiner
Copy link
Contributor

Hi @EPNW-Eric, thank you for opening the pull request.
Have you tried if simply changing the repo name and the organisation without changing the protocol would also work? I.e. not adding the https bit.

url = [email protected]:matomo-org/matomo.git

@EPNW-Eric
Copy link
Contributor Author

It didn't work for me without changing the protocol:

git clone git@github.com:matomo-org/matomo.git
Cloning into 'matomo'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Could also be a mistake on my end, but using https it worked.

@sgiehl
Copy link
Member

sgiehl commented May 9, 2023

using git or https only makes a difference in the way the used git client tries to authenticate. As both repos are public that actually shouldn't make that much difference, but using https should be fine as well I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants