fix: constraints persistence and precedence issues #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #869 where setConstraints calls would not persist after refresh and could not override addPanel constraints. Changes: - Fix critical bug in DockviewGroupPanel constructor (minimumWidth was using maximumHeight) - Restore setConstraints method to DockviewPanelApi by removing from Omit list - Implement explicit constraint tracking to allow group constraints to override panel constraints - Add constraint change listener to track when setConstraints is called explicitly - Update constraint getter precedence: explicit setConstraints > panel constraints > defaults - Update tests to reflect new behavior where group constraints can override panel constraints The new constraint hierarchy ensures that: 1. Explicit setConstraints calls take highest priority 2. Panel constraints from addPanel are used when no explicit group constraints exist 3. Group defaults are used as fallback 4. Constraints persist properly after page refresh 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eec2ae0:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #869 where setConstraints calls would not persist after refresh and could not override addPanel constraints.
Changes:
The new constraint hierarchy ensures that:
🤖 Generated with Claude Code