Correct TaskManager5inch net up/down display #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two values appear transposed
rWolstenholme
commented
Jul 4, 2024
| @@ -307,7 +307,7 @@ STATS: | |||
| SHOW: True | |||
| SHOW_UNIT: True | |||
| X: 202 | |||
| Y: 324 | |||
| Y: 346 | |||
There was a problem hiding this comment.
Matches DN label
turing-smart-screen-python/res/themes/TaskManager5inch/theme.yaml
Lines 42 to 45 in 67661cb
rWolstenholme
commented
Jul 4, 2024
| @@ -317,7 +317,7 @@ STATS: | |||
| SHOW: True | |||
| SHOW_UNIT: True | |||
| X: 202 | |||
| Y: 346 | |||
| Y: 324 | |||
There was a problem hiding this comment.
Matches UP label
turing-smart-screen-python/res/themes/TaskManager5inch/theme.yaml
Lines 34 to 37 in 67661cb
|
Thanks for the fix @rWolstenholme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two values appear transposed - UP is showing download speed, and DN is showing upload speed. This swaps them.
Looking at the code for the labels, you can confirm the Y values now correspond with the correct data.
Thanks! Great project, great theme.