Add support for nanosecond and integer units in DateTime.add/4 #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir
DateTime.add/4supports a variety of units:Currently
Tzworks with:day,:hour,:minute,:second,:millisecondand:microsecond, but it can't work when the unit is:nanosecondor some "strictly positive integer" as we can see in thetest.exsscript below:This PR adds support for these other
units.P.S. I added a commit flagging the tests as
async: trueandUpdaterTestwithupdatedso we can run all other tests excluding it withmix test --exclude updater, if that's not desirable let me know and I can revert that.