Fix reeact 17.0.2 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @mathew-kurian on Vercel. @mathew-kurian first needs to authorize it. |
farandal
commented
Aug 15, 2021
| @@ -441,25 +442,6 @@ export default class OrgChart<T> extends React.Component< | |||
| return { prevProps: props }; | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
There was a problem hiding this comment.
Not sure if I'm breaking some backward compatibility case by removing this, thus, for my react typescript environment, I had to totally remove componentWillMount, and componentWillReceiveProps , in order to avoid errors.
farandal
commented
Aug 15, 2021
| @@ -100,8 +100,9 @@ class SingleFishboneLayoutAdapter extends LayoutStrategyBase { | |||
| this.SpecialRoot = new TreeNodeView( | |||
| Box.Special(Box.None, realRoot.Element.Id, true) | |||
| ); | |||
| (this.SpecialRoot.Level = this.RealRoot.Level), | |||
| (this.SpecialRoot.ParentNode = this.RealRoot); | |||
|
|
|||
There was a problem hiding this comment.
As far as I can see, this syntax does practically the same; thus I had to change it as Typescript 4.5.0-dev was not capable to recognise the syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.