fix connection problem.zoo #577
Open
+71
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| input_data = _load_tensor_from_url(input_url, ["x", "y", "mu1", "mu2"]) | ||
| output_data = _load_tensor_from_url(output_url, ["u"]) | ||
|
|
There was a problem hiding this comment.
Looking at the test times, I think that loading data from URL takes too long. The timeout attribute has no control over the download time, but rather on the response time, as written on the documentation:
timeout is not a time limit on the entire response download; rather, an exception is raised if the server has not issued a response for timeout seconds (more precisely, if no bytes have been received on the underlying socket for timeout seconds). If no timeout is specified explicitly, requests do not time out.
Maybe we should think about a different solution, what is your opinion @dario-coscia @FilippoOlivo?
GiovanniCanali
approved these changes
May 16, 2025
dario-coscia
added
pr-to-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #572.
Checklist