Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #386 #423

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

fix #386 #423

wants to merge 7 commits into from

Conversation

gares
Copy link
Member

@gares gares commented Jun 13, 2024

fix #386

@proux01
Copy link
Contributor

proux01 commented Jun 18, 2024

@gares could you try proux01@bc02eab

@gares
Copy link
Member Author

gares commented Jun 19, 2024

done, but I think there was a "race"

@proux01
Copy link
Contributor

proux01 commented Jun 19, 2024

Indeed, my bad, I rebased the branch, relaunching should now work.

@gares
Copy link
Member Author

gares commented Jun 19, 2024

Now it works, but the OOthm fails (as in Coq's CI for your PR).
So it is good enough to bench mathcomp

@proux01
Copy link
Contributor

proux01 commented Jun 20, 2024

Bench is a bit disappointing, the last commit use primproj for class->mixin builders actually makes things a bit slower:

  • mathcomp
    • before: 13:30, 1772552 kb
    • after: 13:55, 1756420 kb (+3%)
  • analysis
    • before: 12:46, 1771820 kb
    • after: 13:13, 1804272 kb (+4%)

@CohenCyril
Copy link
Member

I suspect a proper use of universe polymorphism will have a better impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[primitive] HB.mixin breaks the types of constants lifting mixin projections
3 participants
@gares @proux01 @CohenCyril