do not crash if the key has no name #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
commented
Mar 31, 2021
| has-cs-instance (global GR) (cs-instance _ (cs-gref GR) _) :- !. | ||
| has-cs-instance (app[global GR|_]) (cs-instance _ (cs-gref GR) _) :- !. | ||
| has-cs-instance (prod _ _ _) (cs-instance _ cs-prod _) :- !. | ||
| has-cs-instance (sort U) (cs-instance _ (cs-sort U) _) :- !. |
There was a problem hiding this comment.
Suggested change
| has-cs-instance (sort U) (cs-instance _ (cs-sort U) _) :- !. | |
| has-cs-instance (sort U) (cs-instance _ (cs-sort U) _) :- !. | |
| has-cs-instance (fun _ _ _) _ :- coq.version _ _ N _, N < 14, coq.error "Coq cannot handle canonical values which are anonymous functions". | |
| has-cs-instance (fun _ _ _) _ :- coq.version _ _ N _, N >= 14, coq.error "NYI: canonical values which are anonymous functions". |
There was a problem hiding this comment.
@CohenCyril is this what you want? It is unclear what to do when we move to Coq 8.14 (assuming it gets support for cs-fun canonical value)
|
This PR is still actual, the code for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.