-
Notifications
You must be signed in to change notification settings - Fork 53
instead of lspace_master #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
instead of lspace_master #1624
Conversation
The last commit renames the HB structure |
a7dcd80
to
7a253c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issues about the conjugate should be solved before merging.
theories/hoelder.v
Outdated
|
||
Local Notation "'N_ p [ f ]" := (Lnorm mu p f). | ||
|
||
Lemma Lnorm1 f : 'N_1[f] = \int[mu]_x `|f x|%:E. | ||
Lemma Lnorm0 p : 1 <= p -> 'N_p[cst 0] = 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this would be better, and perhaps
Lemma Lnorm0 p : 1 <= p -> 'N_p[cst 0] = 0. | |
Lemma Lnorm0 p : p != 0 -> 'N_p[cst 0] = 0. |
Or even without condition when we enable (mu (f @^-1` (setT `\ 0%R))) when p = 0
(which looks like a saner convention than the current one)?
No need to fix this right away, but maybe open an issue.
theories/hoelder.v
Outdated
match p with | ||
| r%:E => [get q : R | r^-1 + q^-1 = 1]%:E | ||
| +oo => 1 | ||
| -oo => 0 | ||
end. | ||
|
||
Lemma conjugateE : | ||
conjugate = if p is r%:E then (r * (r-1)^-1)%:E | ||
else if p == +oo then 1 else 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two look a bit awkward, I would posit the other way around, without match and making it a bijection of extended reals relating
match p with | |
| r%:E => [get q : R | r^-1 + q^-1 = 1]%:E | |
| +oo => 1 | |
| -oo => 0 | |
end. | |
Lemma conjugateE : | |
conjugate = if p is r%:E then (r * (r-1)^-1)%:E | |
else if p == +oo then 1 else 0. | |
if p == +oo then 1 else if p == 0 then -oo else p / (p - 1). | |
Local Notation "p^*" := holder_conjugate. | |
Lemma hoelder_conjugate_eq1 : p > -oo -> p^-1 + p^*^-1 = 1. |
and add lemmas:
Lemma hoelder_conjugate1 : 1^* = +oo.
Lemma hoelder_conjugate2 : 2^* = 2.
Lemma hoelder_conjugatey : +oo^* = 1.
Lemma hoelder_conjugateP p q : p > -oo -> p^-1 + q^-1 = 1 <-> q = p^*.
Lemma hoelder_conjugate0 : 0^* = -oo.
Lemma hoelder_conjugateNy : -oo^* = 0.
Lemma hoelder_conjugateK : involutive hoelder_conjugate.
Lemma hoelder_Mconjugate : p > -oo -> p != 0 -> p * p^* = p + p^*.
Lemma hoelder_div_conjugate : p > -oo -> p != 0 -> p / p^* = p - 1.
Lemma hoelder_conjugate_div : p > -oo -> p != 0 -> p^* / p = p^* - 1.
theories/hoelder.v
Outdated
Local Open Scope classical_set_scope. | ||
Local Open Scope ereal_scope. | ||
|
||
Definition conjugate := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definition conjugate := | |
Definition hoelder_conjugate := |
#[deprecated(since="mathcomp-analysis 1.10.0", | ||
note="use `minkowski_EFin` or `eminkowski` instead")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there are already users... is it worth doing a two-stage deprecation notice?
#[deprecated(since="mathcomp-analysis 1.10.0", | ||
note="use `minkowski_EFin` or `eminkowski` instead")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[deprecated(since="mathcomp-analysis 1.10.0", | |
note="use `minkowski_EFin` or `eminkowski` instead")] | |
#[deprecated(since="mathcomp-analysis 1.10.0", | |
note="use `minkowski_EFin` or `minkowski` instead")] |
Qed. | ||
|
||
(* TODO: rename to minkowski after version 1.12.0 *) | ||
Lemma eminkowski f g (p : \bar R) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lemma eminkowski f g (p : \bar R) : | |
Lemma minkowski f g (p : \bar R) : |
Indeed the functions f
anf g
are still with values in R
while they could be in \bar R
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there are already users... is it worth doing a two-stage deprecation notice?
@@ -122,7 +229,7 @@ Let measurableT_comp_powR f p : | |||
measurable_fun [set: T] f -> measurable_fun setT (fun x => f x `^ p)%R. | |||
Proof. exact: (@measurableT_comp _ _ _ _ _ _ (@powR R ^~ p)). Qed. | |||
|
|||
Local Notation "'N_ p [ f ]" := (Lnorm mu p f). | |||
Local Notation "'N_ p [ f ]" := (Lnorm mu p (EFin \o f)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lemmas relying on this specialization should be future proof for when the restriction on the argument of the norm is lifted. i.e. when this become Local Notation "'N_ p [ f ]" := (Lnorm mu p f).
, in particular eminkowski
might be a misnommer (see comment below).
527c36e
to
98900a9
Compare
Motivation for this change
Closes #1506
I wasn't able to rebase, hence the new PR closing the old one. @hoheinzollern @CohenCyril @proux01 @t6s
Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers