Deprecate CifParser init support of filename as StringIO
#4531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__init__ofCifParsertofrom_strRevert accidentally removed filename asreverted, guess this was not intended, also doesn't agree with type/docstringTextIOWrappersupport (though this may not be intended) in Improve type annotations and comments forio.cif#3820, add a deprecation warningfilenameofCifParserconstructor could also be the string for the CIF file itself (StringIO), it's a bit confusing (cc @ka-sarthak) but I guess this was intended to supportfrom_str. After this refactoring this could be deprecated I guess