-
Notifications
You must be signed in to change notification settings - Fork 131
[WIP] LAMMPS Flows #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vir-k01
wants to merge
229
commits into
materialsproject:main
Choose a base branch
from
vir-k01:lammps_flows_templated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] LAMMPS Flows #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture, copied over all the work done on atomate2-lammps (by @ml-evs and @gbrunin at Matgenix). The basic functions have been implemented, the actual tasks to be done are generating the right input sets for a wide range of lammps calculations that can be done, and to write a task doc that can handle the outputs of these calculations. Will update the run.py once I get it to work with a complied version of lammps for a simple test case.
…, run_lammps can now be executed
… are probably better expressed in the LAMMPS_CMD, which is specified through the environment's atomate2.yaml file.
…o MDA via a builder
…tter output processing into the taskdoc
…rs from pmg, better handling of inputs to the makers. TODO: make init more readable, and allow for better management of how upstream generators call base set generator
Update atomate2
… based on atomate2.ase.utils.TrajectoryObserver. Also accounted for reading in molecules and saving as a trajectory.
…s to json files for easier access, added utility funcs to process settings dicts
…ings to allow restart keyword to be provided in template
…and langevin/berendsen for now. Added nph as a thermostat too.
…for langevin, need for nve integrator for nvt/npt with non-nose-hoover
… in update_settings function
…ded template and for minimization calcs
… take in TaskState and StoreTrajectoryOption objects from emmet for consistency
… default init, ruff
…topology info, fix return type in Dumpconverteer
sync to main
Update to main
…into lammps_flows_templated
…trajectory enum so saving of dump files can be turned off
Member
|
@vir-k01 Let us know once you have addressed @gpetretto 's comments. I am happy to help getting this merged as well. |
Sync to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an effort that picks up from #173 to incorporate workflows to run LAMMPS in atomate2. Quite a bit of the initial code was taken from the atomate2-lammps add-on (here) written by @ml-evs and @gbrunin. The input set generator and templates have been moved to pymatgen.io.lammps, and a concurrent PR has been opened to integrate those into pymatgen. Also tagging in @esoteric-ephemera who helped structure some of the code here, and @davidwaroquiers for their interest in this PR.
TODO