Refactor interval so hands tick over at proper time / upgrade expo #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out an iOS folder
|
Hey, @gorbypark! Thanks for spotting the bug and fixing it. Will try to test this and get it merged soon. Nice work on the upgrade as well 🚀 |
mateoguzmana
approved these changes
Sep 30, 2023
|
Fixed #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The way the existing interval and state was setup, the minute and hour hands would tick over one minute / one hour after the component was created. I refactored the interval and state related to the current date to make sure the hands act properly.
I also upgrade the example project from expo SDK46 to SDK49 since 46 is depreciated and it's not possible to run in Expo Go.
This should fix my own issue.
Test Plan
None really.
Screenshoots