Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueMenta-dark #310

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

BlueMenta-dark #310

wants to merge 4 commits into from

Conversation

0x0000ff
Copy link

@0x0000ff 0x0000ff commented Nov 7, 2023

A dark version of the BlueMenta theme- as the title would suggest
Screenshot at 2023-11-07 23-15-28
Screenshot at 2023-11-07 23-18-56

So far, the brisk menu has menu highlighting colors that hide the text and firefox's csd is missing the minimize button.
Screenshot at 2023-11-07 23-36-58

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just installed this for testing. Similar in some ways to adwaita-dark save for black views rather than the dark grey GNOME used-and NOT using symbolic icons by default, a huge plus for many MATE users.. Also proper MATE support that adwaita does not explicitly build in but which we try to cover with same defaults in our applications.

Personally I would have used the dark grey views, a bit easier on the eyes but that's just me. Note that video editing is a common use for dark themes, as many prefer to have the playing clips as the only bright element on-screen. None the less, I'm all for adding this, as it gives another option without adding a lot of maintainance burden as it's a recoloration of BlueMenta. That should mean same bugs and same fixes.

My views may be unique as the UbuntuStudio GTK theme of 2008 vintage and my GTK3 port of it (UbuntuStudio_Legacy) is a mixed light/dark theme. Audio editing rather than video editing along with still photo work seemed to have been the focus of UbuntuStudio at that time, thus not using a full-dark theme. I have never seen another mixed theme.

@raveit65
Copy link
Member

raveit65 commented Nov 9, 2023

I prefer the light BlueMenta but the dark variant looks very nice.
With a quick test i see that the unfocuses titlebar text color isn't readable on a dark background.
I think it's C_title_unfocused in metacity theme-2/3.
Do you like to maintain the theme?

@raveit65
Copy link
Member

@0x0000ff
Any news?
To be clear i do not have any free resource to maintain another theme.
So, without a new maintainer i can't add the theme.
But maybe @mate-desktop/core-team has a different opinion

@lukefromdc
Copy link
Member

I don't really have additional time to take on maintaining another theme myself. I am also worried about "bus factor" with the political hornet's nest in my country this year

@0x0000ff
Copy link
Author

0x0000ff commented Feb 25, 2024 via email

@lukefromdc
Copy link
Member

lukefromdc commented Feb 25, 2024 via email

@0x0000ff
Copy link
Author

0x0000ff commented Feb 26, 2024 via email

@0x0000ff
Copy link
Author

Screenshot at 2024-02-26 22-50-47

@0x0000ff
Copy link
Author

0x0000ff commented Feb 26, 2024 via email

@0x0000ff
Copy link
Author

0x0000ff commented Feb 29, 2024

I also made changes to the focused title text to make the letters have more of an engraved effect. Would you want that included?
Screenshot at 2024-02-29 15-48-33

@lukefromdc
Copy link
Member

I found one error in this, mate-appearance-properties will show it with
(mate-appearance-properties:55838): Gtk-WARNING **: 14:20:19.545: Theme parsing error: gtk-main.css:11:62: Missing semicolon at end of color definition

line 11 in gtk-main
@define-color theme_unfocused_base_color @insensitive_bg_color, 1.015; /* I don't want the same color, hope not to hurt usability to much here */

Should be

`@define-color theme_unfocused_base_color shade (@insensitive_bg_color, 1.015); /* I don't want the same color, hope not to hurt usability to much here */``

which is the same way bluementa and menta handle thios

@lukefromdc
Copy link
Member

I can confirm this fixes the problem, no errors reported here on using the theme with this applied. Waiting for another review since this is a whole new theme and more to maintain

@lukefromdc lukefromdc requested review from a team September 12, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants