-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for elogind #253
base: master
Are you sure you want to change the base?
Conversation
Uses similar patch to the one already included in mate-screensaver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have systemd not elogind on Debian Unstable (Sid) but this configured fine and built fine. Config messages worked, showing
Configure summary:
mate-system-monitor 1.27.0
==========================
Source code location: .
C Compiler: gcc
CFLAGS:
WARN_CFLAGS: -Wall -Wmissing-prototypes
C++ Compiler: g++
CXXFLAGS:
Elogind support: no
WARN_CXXFLAGS: -Wall -Woverloaded-virtual
Maintainer mode: no
Systemd support: yes
wnck support: yes
Note that we also support building on meson and this only changes the options in autotools.
@lukefromdc I am not so familiar with meson. Happy to get some guidance here. I myself don't know enough about it to teach it either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot test this because I'm not gonna install libelogind which has serious consequences on other packages here and I don't wanna deal with it. I could try in a VM, but call me lazy for now.
Anyway, I don't think this PR works as-is, even with libelogind installed I doubt the linking phase would work, as the library wouldn't be used on the link command. If it does work, please explain how comes.
I myself don't know enough about meson to help with that, I can build with it and test packages but have not yet written or substantially modified meson configuration files. |
@cwendling I refactored my patch according to your suggestions.
|
With no landline I cannot download distro installers to test. If I did they'd go on extra drives as I also have no VM experience. Thus I have no way to test any of the non-systemd stuff |
Uses similar patch to the one already included in mate-screensaver.