Remove compilation warning fix data type format error

[zhuyaliang]

No description provided.

[raveit65]

I found only a few warnings in previous builds but for most changes i do not see any warning.
Eg. where do you see data type format error ?

[zhuyaliang]

Compile warnings can appear using meson build

src/gpm-phone.c:394:18: warning: format '%i' expects argument of type 'int', but argument 4 has type 'guint' {aka 'unsigned int'} [-Wformat=]

[raveit65]

Hmm, normally i use auto-tools and i don't see the warnings with --enable-compile-warnings=maximum. So compiler flags are different in meson :/
Also with meson setup build -Dprefix=/usr -Dwarning_level=everything i don't see this warning.

[raveit65]

Ok, i see the warnings now.

[raveit65]

I could confirm most of warnings with

export CFLAGS='-Wsign-compare -Wformat-signedness -Wformat=2 -Wswitch-default -Wcast-function-type -Wdeclaration-after-statement'

./autogen.sh --enable-compile-warnings=maximum

But not all. It's really difficult to review for me when cflags are different with auto-tools and meson. It took me several hours to understand why you want to change parts of the code.

[lukefromdc]

This looks like at some point in the history of this code (presumably not when it was first written...) signed and unsigned integers got mixed up. Yes, this should be fixed.

[lukefromdc]

This is an all-in-one for a variety of code issues, builds and installs fine here. Looking at the code I see fixes for mixing signed and unsigned integers in debug messages, a prototype warning fix, and a style fix in gpm_applet_create_popup where we declare four variables together instead of two at the start and two later inline.

Looks like a good code cleanup to me, and doing this as an all-in-one means fewer PR's to deal with at the expensive of one more complex review, which is fine by me.

[raveit65]

Code changes are looking good to me.
m-p-m runs fine on desktop machine.
Not tested on my notebook with full battery, brightness an power-management support as i do not run 1.27 on this device.

[raveit65]

@zhuyaliang
Can you please post warnings cflags for next future PR if it so huge again?
This will make reviewers life easier

[lukefromdc]

Anyone else want to review this or is it ready to go?

[raveit65]

I tested it again on my notebook and power management and brightness function are working.
Let's merge it.