replace deprecated Gtk image menu item* #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukefromdc
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
This works as promised, and a string search of the source code for
gtk_image_menu_item returns nothing, indication all direct uses of it have been found. The popup menus for the power manager icon, the brightness applet, and the inhibit applet all show their icons unless the gsettings value org->mate->desktop->interface-> menus-have-icons is set to FALSE. This preference works as before.
zhuyaliang
reviewed
Oct 16, 2023
|
@zhuyaliang |
raveit65
force-pushed
the
gtk-image-menu-item
branch
from
fbb9d4e to
fab6382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian CI build failed because of
https://app.travis-ci.com/github/mate-desktop/mate-power-manager/jobs/611594502#L4174
It's not related to PR bcause it fails in master too.
https://app.travis-ci.com/github/mate-desktop/mate-power-manager/jobs/608158792#L3413
Looks like the same issue than with mate-system-monitor mate-desktop/mate-system-monitor#254