Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wmissing-prototypes warnings #381

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix -Wmissing-prototypes warnings #381

merged 1 commit into from
Aug 23, 2022

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Aug 4, 2022

Test:

 CFLAGS="-Werror=missing-prototypes" ./autogen.sh --prefix=/usr && make && sudo make install

Warnings

mate-power-manager.make.log:brightness-applet.c:910:1: warning: no previous prototype for function 'gpm_brightness_applet_dbus_connect' [-Wmissing-prototypes]
mate-power-manager.make.log:brightness-applet.c:954:1: warning: no previous prototype for function 'gpm_brightness_applet_dbus_disconnect' [-Wmissing-prototypes]
mate-power-manager.make.log:brightness-applet.c:982:1: warning: no previous prototype for function 'gpm_brightness_applet_name_vanished_cb' [-Wmissing-prototypes]
mate-power-manager.make.log:inhibit-applet.c:362:1: warning: no previous prototype for function 'gpm_inhibit_applet_dbus_connect' [-Wmissing-prototypes]
mate-power-manager.make.log:inhibit-applet.c:399:1: warning: no previous prototype for function 'gpm_inhibit_applet_dbus_disconnect' [-Wmissing-prototypes]
mate-power-manager.make.log:inhibit-applet.c:429:1: warning: no previous prototype for function 'gpm_inhibit_applet_name_vanished_cb' [-Wmissing-prototypes]

cwendling
cwendling approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@cwendling cwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thesquash
thesquash approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@thesquash thesquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good find @rbuj.

@thesquash thesquash merged commit 954614b into master Aug 23, 2022
@thesquash thesquash deleted the missing-prototypes branch August 23, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesquash thesquash thesquash approved these changes

@cwendling cwendling cwendling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuj @cwendling @thesquash