Add support for gaming inputs #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuj
approved these changes
Feb 17, 2022
Sorry, I didn't see those change when I committed. |
|
See my gaming-input branch without the po changes. |
Looks good, but this needs to be revert here before merging. Your master branch is used here. |
|
Cannot test this, I don't have the hardware |
|
I wasn't able to change master without closing this pull request, so see the clean pull request #376 without the .po changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for gaming inputs as well as their icons.
In addition, display the device name even if the vendor is empty.
I tested this with my DualShock 3 connected over bluetooth.
Here is how it looks with this change:
And how it looks without the change:
