Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning -Wunused-but-set-variable #359

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Dec 21, 2020

No description provided.

@rbuj rbuj requested a review from a team December 21, 2020 12:37
@raveit65
Copy link
Member

It seems you fixed those warnings.

gpm-statistics.c: In function 'main':

gpm-statistics.c:1205:8: warning: variable 'retval' set but not used [-Wunused-but-set-variable]

 1205 |  guint retval;

gsd-media-keys-window.c: In function 'msd_media_keys_window_init':

gsd-media-keys-window.c:651:20: warning: variable 'screen' set but not used [-Wunused-but-set-variable]

  651 |         GdkScreen *screen;

Ok one in gpm-manager.c: is left.

@rbuj
Copy link
Contributor Author

rbuj commented Dec 28, 2020

I didn't fix it because it's related to migrating from dbus to gdbus.

        DBusGConnection *connection; /* dbus */
        GDBusConnection *g_connection; /* gdbus */
...
        connection = dbus_g_bus_get (DBUS_BUS_SESSION, &error); /* #include <dbus/dbus-glib.h> */
        g_connection = g_bus_get_sync (G_BUS_TYPE_SESSION, NULL, &error); /* #include <gio/gio.h> */

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
builds and runs fine.

@raveit65 raveit65 requested a review from a team December 28, 2020 14:30
@raveit65 raveit65 merged commit 46a1d42 into master Jan 7, 2021
@raveit65 raveit65 deleted the unused-but-set-variable branch January 7, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants