Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix switch-windows-all hotkey #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnk
Copy link
Contributor

@dnk dnk commented Mar 9, 2023

pass focus to window if it is on another workspace.

current behavior:

  1. there are 2 windows on workspace A and window 2 is above window 1
  2. switch to workspace B
  3. use "switch-windows-all" keys to switch to window 1

actual result:
window 1 get "demands attention" mark.
focus passed to window 2.

with this changes:
focus passed to window 1. window 1 is raised above all normal windows.

there is still problem with stealing focus by "always on top" windows. it can fixed separately.

pass focus to window if it is on another workspace
@dnk dnk closed this Mar 9, 2023
@dnk dnk reopened this Mar 9, 2023
@dnk
Copy link
Contributor Author

dnk commented Mar 21, 2023

known problem:
scenario:
there are 2+ monitors
workspace 1:

  • application A on monitor 1
  • application B (Atom text editor) on monitor 2
    active workspace 2
    switch to application A using "switch-windows-all" hotkey

actual result:
application B (Atom text editor) on monitor 2 displays invalid image.

the same problem appeared by just switching workspaces.

may be there is bug in Atom text editor.

@lukefromdc lukefromdc requested a review from a team April 3, 2023 03:39
Copy link

@Rambo1377 Rambo1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/window.c

@lukefromdc
Copy link
Member

This isn't something I can easily test as its so far outside my workflow. I have never used a switch-windows-all hotkey and the entire described workflow is out of my experience.It would not be visually obvious to me if this was working right or not.

We have one approving review and the code change itself is simple. Hoping we can get a second review on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants