Develop-update main.py >Mutable and Immutable #2592
Conversation
There was a problem hiding this comment.
Review Summary
Thank you for your work! There's just one critical issue to fix: the set variable (collection_of_coins) is included in the "mutable" list, but according to the task requirements, only lists and dictionaries should be considered mutable for this exercise. Please remove the set from the "mutable" list so your solution matches the example and requirements. Once you make this small adjustment, your code will be perfect! 😊
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
There was a problem hiding this comment.
Review Summary
Thank you for your work! There is one critical issue: the set variable collection_of_coins is included in the "mutable" list, but according to the task requirements, only lists and dictionaries should be considered mutable for this exercise. Please remove the set from the "mutable" list. Once you make this small fix, your code will be perfect! Keep going, you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -16,4 +16,7 @@ | |||
| } | |||
| collection_of_coins = {1, 2, 25} | |||
|
|
|||
| # write your code here | |||
| sorted_variables = { | |||
| "mutable": [my_favourite_films, marks, collection_of_coins], | |||
There was a problem hiding this comment.
Issue: The collection_of_coins set is included in the "mutable" list. According to the task requirements, only lists and dictionaries should be considered mutable for this exercise. Please remove the set from the "mutable" list.
There was a problem hiding this comment.
Review Summary
Great job! 🎉 You have successfully addressed the previous review's critical issue by moving the set variable collection_of_coins from the "mutable" list to the "immutable" list, as required by the task. Your sorted_variables dictionary is now correctly structured: it includes all 8 provided variables, with only lists and dictionaries in the "mutable" list, and all other types (including sets) in the "immutable" list. You followed all task requirements, kept your code clean, and placed everything in the correct file without any unnecessary output or extra variables.
Keep up the good work! If you encounter similar requirements in the future, remember to pay close attention to the definitions provided in the task (such as what counts as "mutable" or "immutable"). Well done—you're ready to move forward! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| @@ -16,4 +16,13 @@ | |||
| } | |||
| collection_of_coins = {1, 2, 25} | |||
|
|
|||
| # write your code here | |||
| sorted_variables = { | |||
| "mutable": [my_favourite_films, marks, collection_of_coins], | |||
There was a problem hiding this comment.
Issue: The collection_of_coins set is included in the "mutable" list. According to the task requirements, only lists and dictionaries should be considered mutable for this exercise. Please remove the set from the "mutable" list.
No description provided.