add header moyo #5743
add header moyo #5743
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request. Firstly, the <a> tag for the logo image is missing an href attribute, which is essential for making it a clickable link to the homepage. This impacts the functionality of the navigation. Additionally, consider adding a fallback font in the font-family property to ensure better compatibility across different browsers and systems. Once these issues are resolved, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a class="logo-img"> |
There was a problem hiding this comment.
The <a> tag for the logo image should have an href attribute to make it a clickable link, typically pointing to the homepage.
src/style.css
Outdated
| body { | ||
| margin: 0; | ||
| font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Consider adding a fallback font in the font-family property for better compatibility across different browsers and systems.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Great job on addressing the previous issues! 🎉 Your code now meets the task requirements and constraints. The HTML and CSS files are well-structured and organized, with semantic tags and effective styling. The logo is correctly linked, and a fallback font has been added for better compatibility. The use of CSS variables and pseudo-elements enhances maintainability and design consistency. Although there are no critical issues, remember to review the comments to refine your skills further. Keep up the good work, and continue learning from each experience! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️