add task solution #5739
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test | ||
| - name: Upload HTML report(backstop data) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: backstop_data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,71 @@ | ||
| :root { | ||
| --primary-color: #00acdc; | ||
| --primary-background: #fff; | ||
| --primary-background-alternative: #e5e5e5; | ||
| --primary-text-color: #000; | ||
| --font-family: 'Roboto', serif; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| header { | ||
| background-color: var(--primary-background); | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 0 50px; | ||
|
There was a problem hiding this comment. The padding is set to a fixed value of 50px. Consider using relative units like percentages or rems for better responsiveness across different screen sizes. |
||
| } | ||
|
|
||
| .navigation__logo { | ||
| display: flex; | ||
| } | ||
|
|
||
| .navigation__list { | ||
| display: flex; | ||
| list-style: none; | ||
| padding: 0; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .navigation__item { | ||
| margin-left: 20px; | ||
| } | ||
|
|
||
| .navigation__item:first-child { | ||
| margin-left: 0; | ||
| } | ||
|
|
||
| .navigation__link { | ||
| height: 60px; | ||
|
There was a problem hiding this comment. The height is set to a fixed value of 60px. Consider using relative units or media queries to adjust this for different screen sizes. |
||
| display: flex; | ||
| align-items: center; | ||
| text-decoration: none; | ||
| text-transform: uppercase; | ||
| color: var(--primary-text-color); | ||
| font-family: var(--font-family); | ||
| font-weight: 500; | ||
| font-style: normal; | ||
| font-size: 12px; | ||
|
There was a problem hiding this comment. The font size is set to 12px, which might be too small for readability on some devices. Consider using relative units like em or rem for better accessibility. |
||
| } | ||
|
|
||
| .navigation__link:hover { | ||
| color: var(--primary-color); | ||
| } | ||
|
|
||
| .is-active { | ||
| color: var(--primary-color); | ||
| position: relative; | ||
| } | ||
|
|
||
| .is-active::after { | ||
| content: ''; | ||
| display: block; | ||
| height: 4px; | ||
| width: 100%; | ||
| position: absolute; | ||
| border-radius: 8px; | ||
| background-color: var(--primary-color); | ||
| bottom: 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href attribute is currently set to '#', which is a placeholder. Consider replacing it with a valid URL or a JavaScript function if this is intended to be a clickable link.