Finished moyo_Header #5737
Finished moyo_Header #5737
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 The code mostly meets the task requirements, with only a few minor issues that don't impact the core functionality. Consider addressing the empty href attribute for the logo link, adding the crossorigin attribute for better performance, and reviewing the necessity of the border-radius on the ::before pseudo-element. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| href=" " |
There was a problem hiding this comment.
The href attribute is empty. Consider providing a valid URL or a placeholder (#) to ensure the link is functional.
| /> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" |
There was a problem hiding this comment.
Consider adding the crossorigin attribute to the preconnect link for fonts.gstatic.com to improve performance by allowing the browser to make the connection earlier.
| width: 100%; | ||
| height: 4px; | ||
| background-color: var(--navhover-color); | ||
| border-radius: 8px; |
There was a problem hiding this comment.
The border-radius property on the ::before pseudo-element might not be necessary if the intention is to create a straight line indicator. Consider removing it unless a rounded line is desired.
DEMO LINK
TEST REPORT LINK